Dev/errors - #162
Open
luk384090-cloud wants to merge 21 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances error handling, response validation, and compatibility across the DashScope CLI and SDK, including mapping SDK errors to CLI-friendly codes and adding unit tests. The review feedback highlights several critical issues where the new validation logic strictly assumes dictionary outputs, which will cause runtime crashes or failures when API responses are objects. It is recommended to update these checks to dynamically support both dictionary and object formats.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
lzsweb
reviewed
Jul 15, 2026
lzsweb
reviewed
Jul 16, 2026
lzsweb
reviewed
Jul 16, 2026
lzsweb
reviewed
Jul 16, 2026
added 7 commits
July 16, 2026 18:54
lzsweb
reviewed
Jul 21, 2026
AgentStudio exceptions now converge onto dashscope.common.error_registry
(the single source of truth shared with the Java SDK). from_response
normalizes the server code to the unified Anthropic-compatible taxonomy
(rewriting legacy aliases, preserving specific registry codes like
billing_error, falling back to the per-status row when the server omits
one) so .code is always unified; the raw payload stays on .raw. Default
messages are sourced from the registry with unresolved {var} placeholders
stripped, fixing a 404 placeholder leak and a 504 code/message mismatch.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…rd SDK exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this PR does and why]
Related Issue: Fixes #[issue_number] or Relates to #[issue_number]
Security Considerations: [Check if API keys or sensitive credentials are exposed in code/logs]
Type of Change
Component(s) Affected
Checklist
Testing
[How to test these changes]
Additional Notes
[Optional: any other context]